-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoTW import fails with 60M band #457
Comments
Found dmUtils.FreqFromBand used in three places:
So it seems that replacing hard coded version with band table lookup does not break anything. While checking this I looked also to default frequencies. They are set with prefrences/TRXcontrol/Change default frequencies button. That would not be very big change after all and would make the preferences/bands/frequencies editing more user friendly. |
dmUtils.FreqFromBand was hard coded to return frequency when band and mode was given. How ever it had a typing error with 60M band that caused LoTW import fail with that band. As hard coded errors are difficult to fix frequency lookup is now moved tocarlog_common.bands where user can edit values via preferences/bands/Frequencies. For more information see issue ok2cqr#457 Squashed commit of the following: commit d70345c Author: OH1KH <[email protected]> Date: Mon Nov 15 21:17:37 2021 +0200 Small fix to phone modes commit b9543a5 Author: OH1KH <[email protected]> Date: Mon Nov 15 21:07:40 2021 +0200 dmUtils.FreqFromBand rewritten
dmUtils.FreqFromBand was hard coded to return frequency when band and mode was given. How ever it had a typing error with 60M band that caused LoTW import fail with that band. As hard coded errors are difficult to fix frequency lookup is now moved tocarlog_common.bands where user can edit values via preferences/bands/Frequencies. For more information see issue ok2cqr#457 Created update to version 5 for cqrlog_common. Added 3 microwave bands. Squashed commit of the following: commit ea685a6 Author: OH1KH <[email protected]> Date: Tue Nov 16 15:33:31 2021 +0200 Added missing 3 microvawe bands to cqrlog_common.bands by database version update to 5 commit d70345c Author: OH1KH <[email protected]> Date: Mon Nov 15 21:17:37 2021 +0200 Small fix to phone modes commit b9543a5 Author: OH1KH <[email protected]> Date: Mon Nov 15 21:07:40 2021 +0200 dmUtils.FreqFromBand rewritten
Error is now fixed by commit, but I still leave this open to remind the suggestion of new bands table format. Using begin and end of modes could allow mode slices appear in different order in band than current and only CW->RTTY(data)->SSB order. |
LoTW import drops all 60M imports to error file.
The reason is fImportProgress line 849:
band := dmUtils.GetBandFromFreq(dmUtils.FreqFromBand(band,'CW'));
dmUtils.FreqFromBand is horrible hard coded list of frequencies versus modes. And there is a typing error with 60M band's
frequency that leads all LoTW imported qsos to be "not found in log" as the "band" above gets empty result.
There is already database table cqrlog_common.bands that holds user editable band start/end/cw/rtty/ssb frequencies.
So why not use that instead of hard coding?
In that table the column "cw" is just pointing at the end frequency of cw slice, but that does not matter. It gives good enough response, I think.
I have done fix that uses database instead of hard coding and in first test all qsos, including 60M, were imported ok from LoTW.
It still needs more testing as dmUtils.FreqFromBand is used from few other places.
While doing tests this issue is open. Test branch is https://github.com/OH1KH/cqrlog/tree/lotw_60m_rcvd_err
The text was updated successfully, but these errors were encountered: