-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abandon #10
Comments
Hi Michael,
I forked your repo as you hadn't update it since you added Laravel 6
support back in Sept 2019, and I wanted to bring it up to date to Laravel
7, then 8, then 9.
https://github.com/olimortimer/LaravelShoppingcart/commits
I noticed your commits recently, and brought mine in line, which yes, means
they are both now identical. If you're planning to continue development of
it, I will certainly drop my fork in favour of yours, and continue to make
changes to your fork in the form of pull requests.
I am still active, and maintain this fork, albeit not as often as I'd like.
…On Wed, 22 Feb 2023, 21:35 Michael V., ***@***.***> wrote:
Hi @olimortimer <https://github.com/olimortimer>
I was checking who forked my fork of LaravelShoppingcart and I see you're
the only one.
I don't remember why you forked it but I think it's safe to say you can
abandon this repo and in packagist you can suggest
michaelbelgium/shoppingcart
There's no difference between this fork and mine. Unless you plan to add
more features, but then again - you can pull request to mine. And I don't
think you're active anymore on github - or even maintain this one
—
Reply to this email directly, view it on GitHub
<#10>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJCRY644VMRQBGMSIDXPTLWY2BAXANCNFSM6AAAAAAVE3IEGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Oh yeah I see. There was indeed a time i abandoned mine, untill late during laravel 9 or 10 😝 Thanks for continueing it during that time The last changes from past couple days is to focus on php 8.1 and future php versions only, as laravel 10 does. I do plan on keeping it up-to-date and continue development/fixes/adding features if people want to Already doing lot of BC's but it had to happen some day tbh |
Looking forward to the development going forward, and will help the best I can! |
@MichaelBelgium have you thought about adding a repo with a demo store? |
@olimortimer No, not really 😮 |
Hi @olimortimer
I was checking who forked my fork of LaravelShoppingcart and I see you're the only one.
I don't remember why you forked it but I think it's safe to say you can abandon this repo and in packagist you can suggest
michaelbelgium/shoppingcart
There's no difference between this fork and mine. Unless you plan to add more features, but then again - you can pull request to mine. And I don't think you're active anymore on github - or even maintain this one
The text was updated successfully, but these errors were encountered: