Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandon #10

Open
MichaelBelgium opened this issue Feb 22, 2023 · 5 comments
Open

Abandon #10

MichaelBelgium opened this issue Feb 22, 2023 · 5 comments

Comments

@MichaelBelgium
Copy link

Hi @olimortimer

I was checking who forked my fork of LaravelShoppingcart and I see you're the only one.
I don't remember why you forked it but I think it's safe to say you can abandon this repo and in packagist you can suggest michaelbelgium/shoppingcart

There's no difference between this fork and mine. Unless you plan to add more features, but then again - you can pull request to mine. And I don't think you're active anymore on github - or even maintain this one

@olimortimer
Copy link
Owner

olimortimer commented Feb 22, 2023 via email

@MichaelBelgium
Copy link
Author

MichaelBelgium commented Feb 22, 2023

I forked your repo as you hadn't update it since you added Laravel 6
support back in Sept 2019, and I wanted to bring it up to date to Laravel
7, then 8, then 9.

Oh yeah I see. There was indeed a time i abandoned mine, untill late during laravel 9 or 10 😝 Thanks for continueing it during that time

The last changes from past couple days is to focus on php 8.1 and future php versions only, as laravel 10 does. I do plan on keeping it up-to-date and continue development/fixes/adding features if people want to

Already doing lot of BC's but it had to happen some day tbh

@olimortimer
Copy link
Owner

Looking forward to the development going forward, and will help the best I can!

@olimortimer
Copy link
Owner

@MichaelBelgium have you thought about adding a repo with a demo store?

@MichaelBelgium
Copy link
Author

@olimortimer No, not really 😮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants