-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using UNSAFE_componentWillReceiveProps in strict mode is not recommended and may indicate bugs in your code #659
Comments
Hi @AshrinJose , I filed a PR targeting this precise issue, but unfortunately the repo hasn't been active for the last few months. |
Correct, it don't have time to allocate to this repo. It had served this purpose for me in the past, I haven't really spent time on it since the incorporation on MUI Inc. I assume there are better solutions in the React community for solving this problem now, no? |
Hi @oliviertassinari, I imagine you must be quite busy with the awesome MUI library! |
According to their docs, MUI is using this library for their swipe able views, am I right? If so, they may want to allocate some resources to this library or even include it as part of mui/lab |
@oliviertassinari, we would love a merge on the pull request to resolve this issue This repo is a great addition to MUI and is used by many |
Commenting to emphasize this - some projects have this project as a dependency and now have this error too. |
It's frustrating that mui uses this library and we all still have this issue. Kindly asking for a fix. |
Please either fix this or inform the MUI project that this will not be fixed so that project can take appropriate action. |
Just commenting here for others, found from the comment above that shares a PR with the fix that haven't been merged yet but this fixed it for me: #654 (comment) |
Expected Behavior
React warning for UNSAFE_componentWillReceiveProps should be gone.
Current Behavior
Warning: Using UNSAFE_componentWillReceiveProps in strict mode is not recommended and may indicate bugs in your code. See https://reactjs.org/link/unsafe-component-lifecycles for details.
Please update the following components: AutoPlay, ReactSwipableView
Steps to Reproduce (for bugs)
Context
Got React Error in development console about breaking code
Your Environment
| react-swipeable-views | ^0.14.0 |
| React | ^17.0.2 |
The text was updated successfully, but these errors were encountered: