From 4433035b81a979d71100f93e75187431d58ba01f Mon Sep 17 00:00:00 2001
From: Oliver Walsh <owalsh@redhat.com>
Date: Wed, 21 Feb 2024 16:38:53 +0000
Subject: [PATCH] Move ovndb client type to neutron

---
 modules/common/service/types.go             |  2 --
 modules/common/tls/tls.go                   | 14 +-------------
 modules/common/tls/zz_generated.deepcopy.go |  1 -
 3 files changed, 1 insertion(+), 16 deletions(-)

diff --git a/modules/common/service/types.go b/modules/common/service/types.go
index 95a1d68b..d2090ba7 100644
--- a/modules/common/service/types.go
+++ b/modules/common/service/types.go
@@ -52,8 +52,6 @@ const (
 	ProtocolHTTPS Protocol = "https"
 	// ProtocolNone -
 	ProtocolNone Protocol = ""
-	// OvnDbCA - fake endpoint for OVN DB internal CA
-	OvnDbCA Endpoint = "ovndb"
 )
 
 func (e *Endpoint) String() string {
diff --git a/modules/common/tls/tls.go b/modules/common/tls/tls.go
index 5e9084ec..9e5d9e9f 100644
--- a/modules/common/tls/tls.go
+++ b/modules/common/tls/tls.go
@@ -106,11 +106,6 @@ type APIService struct {
 	// +operator-sdk:csv:customresourcedefinitions:type=spec
 	// Internal GenericService - holds the secret for the internal endpoint
 	Internal GenericService `json:"internal,omitempty"`
-
-	// +kubebuilder:validation:optional
-	// +operator-sdk:csv:customresourcedefinitions:type=spec
-	// OVNDb GenericService - holds the secret for the OVNDb client cert
-	OvnDb GenericService `json:"ovndb,omitempty"`
 }
 
 // GenericService contains server-specific TLS secret or issuer
@@ -168,7 +163,7 @@ func (a *APIService) ValidateCertSecrets(
 ) (string, ctrl.Result, error) {
 	var svc GenericService
 	certHashes := map[string]env.Setter{}
-	for _, endpt := range []service.Endpoint{service.EndpointInternal, service.EndpointPublic, service.OvnDbCA} {
+	for _, endpt := range []service.Endpoint{service.EndpointInternal, service.EndpointPublic} {
 		switch endpt {
 		case service.EndpointPublic:
 			if !a.Enabled(service.EndpointPublic) {
@@ -183,13 +178,6 @@ func (a *APIService) ValidateCertSecrets(
 			}
 
 			svc = a.Internal
-
-		case service.OvnDbCA:
-			if !a.Enabled(service.EndpointInternal) {
-				continue
-			}
-
-			svc = a.OvnDb
 		}
 
 		hash, ctrlResult, err := svc.ValidateCertSecret(ctx, h, namespace)
diff --git a/modules/common/tls/zz_generated.deepcopy.go b/modules/common/tls/zz_generated.deepcopy.go
index 2002016c..80ca99bd 100644
--- a/modules/common/tls/zz_generated.deepcopy.go
+++ b/modules/common/tls/zz_generated.deepcopy.go
@@ -45,7 +45,6 @@ func (in *APIService) DeepCopyInto(out *APIService) {
 	*out = *in
 	in.Public.DeepCopyInto(&out.Public)
 	in.Internal.DeepCopyInto(&out.Internal)
-	in.OvnDb.DeepCopyInto(&out.OvnDb)
 }
 
 // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new APIService.