From bc78d13883214b3429de01873ee9ee39607c6ee3 Mon Sep 17 00:00:00 2001 From: Josh Moore Date: Wed, 24 Apr 2024 10:10:25 +0200 Subject: [PATCH 1/5] Update to codecov 4 --- .github/workflows/build.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 265e700c..c26db234 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -27,7 +27,9 @@ jobs: run: tox --conf tox.ini - name: Upload code coverage - uses: codecov/codecov-action@v2 + uses: codecov/codecov-action@v4 with: file: ./coverage.xml fail_ci_if_error: true + env: + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} From a5f22f8838b05e03fc3078a6099a21abb6b2f9a7 Mon Sep 17 00:00:00 2001 From: Josh Moore Date: Wed, 24 Apr 2024 10:12:48 +0200 Subject: [PATCH 2/5] Temporarily gnore A005: 'module is shadowing python builtin module' --- .pre-commit-config.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index e1cd735e..919d608e 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -61,7 +61,7 @@ repos: # Conflicts with PEP8 and black: # W503 line break before binary operator # Does not recognize deprecated directive in docstrings - "--ignore=E203,RST303, W503", + "--ignore=E203,RST303,W503,A005", "--rst-roles=class,func,ref,mod,meth,const", ] From 70df8132ad847bc42f37f13d8034863f3a392d3a Mon Sep 17 00:00:00 2001 From: Josh Moore Date: Wed, 24 Apr 2024 10:16:00 +0200 Subject: [PATCH 3/5] Use builtins-ignorelist --- .pre-commit-config.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 919d608e..d59f06af 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -61,7 +61,8 @@ repos: # Conflicts with PEP8 and black: # W503 line break before binary operator # Does not recognize deprecated directive in docstrings - "--ignore=E203,RST303,W503,A005", + "--ignore=E203,RST303,W503", + "--builtins-ignorelist=csv,io,types", "--rst-roles=class,func,ref,mod,meth,const", ] From c6a20001aa1ec685f65839a88acbfb187dc2f93e Mon Sep 17 00:00:00 2001 From: Josh Moore Date: Wed, 24 Apr 2024 11:30:34 +0200 Subject: [PATCH 4/5] use allow-modules flag --- .pre-commit-config.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index d59f06af..f902557b 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -62,7 +62,7 @@ repos: # W503 line break before binary operator # Does not recognize deprecated directive in docstrings "--ignore=E203,RST303,W503", - "--builtins-ignorelist=csv,io,types", + "--builtins-allowed-modules=csv,io,types", "--rst-roles=class,func,ref,mod,meth,const", ] From b58732cd9dec91dce9a54363a421bedc7c880b09 Mon Sep 17 00:00:00 2001 From: Josh Moore Date: Wed, 24 Apr 2024 12:16:22 +0200 Subject: [PATCH 5/5] Try "with: token:" --- .github/workflows/build.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c26db234..261c4e97 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -31,5 +31,4 @@ jobs: with: file: ./coverage.xml fail_ci_if_error: true - env: - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} + token: ${{ secrets.CODECOV_TOKEN }}