Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics Specs #125

Open
achiurizo opened this issue Sep 11, 2020 · 2 comments
Open

Metrics Specs #125

achiurizo opened this issue Sep 11, 2020 · 2 comments
Labels
Childchain Related to the Childchain M Medium size amount of work metrics Data and health related to the network

Comments

@achiurizo
Copy link
Contributor

achiurizo commented Sep 11, 2020

Specs for all the various Metrics we will want to emit.

Feature: Childchain emits Metrics
	The childchain needs to emit metrics to that we can better
	observe what the Childchain is doing and respond to it in a timely manner.
	
Background:
	Given I am the Childchain

Rule: Needs to emit Metrics for Gold Team / Eng

Scenario: Emits Form Block metrics
Scenario: Emits Block Submission metrics
Scenario: Emits PG/Ecto Metrics
Scenario: Emit Event Listener/Callback Processing metrics

@wip
Rule: Needs to emit Metrics for Product / Business

@wip
Rule: Needs to emit Metrics for Infra
@achiurizo achiurizo pinned this issue Sep 11, 2020
@achiurizo achiurizo added Childchain Related to the Childchain M Medium size amount of work metrics Data and health related to the network labels Sep 11, 2020
@ayrat555 ayrat555 assigned ayrat555 and unassigned ayrat555 Oct 28, 2020
@pgebal pgebal self-assigned this Nov 6, 2020
@pgebal
Copy link
Contributor

pgebal commented Nov 6, 2020

I've read through the code and we emit metrics for event listener:

  • number of processed events per event processing service
  • number of messages in queue

It's the same as in childchain v1. Do we need more?

We use spandex ecto for tracing calls to db. Are we good with that or do we need more?

Looks like the last 2 are done:

  • Scenario: Emits Form Block metrics
  • Scenario: Emits Block Submission metrics
  • Scenario: Emits PG/Ecto Metrics
  • Scenario: Emit Event Listener/Callback Processing metrics

@achiurizo
Copy link
Contributor Author

@pgebal Awesome! Thanks for looking into this. Let's punt on the reminder of this story for now and focus on getting the network deployed before continuing further with this 🙏

@pgebal pgebal removed their assignment Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Childchain Related to the Childchain M Medium size amount of work metrics Data and health related to the network
Projects
None yet
Development

No branches or pull requests

3 participants