Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using namespace in header files #7

Open
PovelikinRostislav opened this issue Feb 11, 2020 · 1 comment
Open

using namespace in header files #7

PovelikinRostislav opened this issue Feb 11, 2020 · 1 comment

Comments

@PovelikinRostislav
Copy link

It's a bad practice to inject using namespace into header files like in sycl_base.hpp:

using namespace std;
using namespace cl::sycl;
using namespace cl::sycl::access;

I'll submit a PR fixing this issue and other polishing stuff (absence of used headers in a list of include files in some examples) as soon as I get some free time.

@nikitaxgusev
Copy link
Contributor

@PovelikinRostislav the issue is fixed, I think, we can close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants