Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Manager: Extract core logic to flowkit package #1633

Open
bartolomej opened this issue Jun 2, 2024 · 0 comments · May be fixed by onflow/flowkit#62 or #1659
Open

Dependency Manager: Extract core logic to flowkit package #1633

bartolomej opened this issue Jun 2, 2024 · 0 comments · May be fixed by onflow/flowkit#62 or #1659
Labels
Feature A new user feature or a new package API

Comments

@bartolomej
Copy link
Contributor

bartolomej commented Jun 2, 2024

Issue To Be Solved

Dependency management logic (used by flow dependencies command group) can't be (re)used by external packages at the moment, as it lives in the flow-cli/internal package.

Suggest A Solution

More core logic (dependencyinstaller.go) to a non-internal package (preferably to flowkit repo, as that's where other such logic already lives), so that other packages or projects can reuse it if needed (useful mostly for other devtools).

This is similar to how DeployProject function lives in flowkit, instead of internal/project package.

Context

This would be useful for Flowser, as we want to build a browser-based Flow playground, which would include an emulator and (a subset of) Flow CLI all running within the browser.

Since we can't just "import" the flow-cli/cmd and use it in the browser like so flowCli.RunCommand("flow dependencies add ...") (made up function for illustration), we'll need to re-implement a subset of Flow CLI commands (which would include contract management commands imo) from scratch and hopefully reuse as much of the underlying core logic as possible to ensure consistent behavior and more code reuse.

For more context, see our grant proposal: onflow/developer-grants#260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new user feature or a new package API
Projects
Status: No status
1 participant