-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): matchConditions added in Validating & MutatingWebhookConfiguration #3100
Conversation
af88e03
to
0e47904
Compare
…iguration Signed-off-by: wlee <[email protected]>
Signed-off-by: wlee <[email protected]>
Signed-off-by: wlee <[email protected]>
@ritazh @maxsmythe ping |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3100 +/- ##
==========================================
+ Coverage 53.68% 53.73% +0.04%
==========================================
Files 136 136
Lines 12198 12198
==========================================
+ Hits 6548 6554 +6
+ Misses 5145 5141 -4
+ Partials 505 503 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leewoobin789 Please fix the CI error
Seems like this change is setting map
in the respective field instead of an array
Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(MutatingWebhookConfiguration.webhooks[0].matchConditions): invalid type for io.k8s.api.admissionregistration.v1.MutatingWebhook.matchConditions: got "map", expected "array"
helm.go:88: [debug] error validating "": error validating data: ValidationError(MutatingWebhookConfiguration.webhooks[0].matchConditions): invalid type for io.k8s.api.admissionregistration.v1.MutatingWebhook.matchConditions: got "map", expected "array"
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]> Co-authored-by: Sertaç Özercan <[email protected]>
) Signed-off-by: Sertac Ozercan <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <[email protected]>
Signed-off-by: Rita Zhang <[email protected]>
…n-policy-agent#3148) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <[email protected]>
…olicy-agent#3150) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <[email protected]>
Signed-off-by: Asya-kawai <[email protected]>
Signed-off-by: Rita Zhang <[email protected]>
…3206) Signed-off-by: Andrew Peabody <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ent#3197) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Sertac Ozercan <[email protected]> Co-authored-by: Jaydipkumar Arvindbhai Gabani <[email protected]>
…olicy-agent#3196) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n-policy-agent#3194) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <[email protected]>
…cy-agent#3258) Signed-off-by: Jaydip Gabani <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Sertac Ozercan <[email protected]> Signed-off-by: Sertaç Özercan <[email protected]> Co-authored-by: Rita Zhang <[email protected]>
…st (open-policy-agent#3289) Signed-off-by: Rita Zhang <[email protected]>
…cy-agent#3301) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jaydip Gabani <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <[email protected]>
…policy-agent#3316) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <[email protected]>
…-agent#3285) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sozercan <[email protected]>
…cy-agent#3293) Signed-off-by: Prachi Pendse <[email protected]>
….2+incompatible (open-policy-agent#3324) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…icy-agent#3319) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Sertac Ozercan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
….5+incompatible (open-policy-agent#3327) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Sertac Ozercan <[email protected]>
…pen-policy-agent#3332) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ent#3334) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Rita Zhang <[email protected]>
Signed-off-by: Rita Zhang <[email protected]>
…icy-agent#3310) Signed-off-by: Ben Couture <[email protected]> Signed-off-by: Ben Couture <[email protected]> Co-authored-by: Rita Zhang <[email protected]>
Signed-off-by: Sertac Ozercan <[email protected]>
Signed-off-by: Sertac Ozercan <[email protected]>
Signed-off-by: Max Smythe <[email protected]> Signed-off-by: Max Smythe <[email protected]> Co-authored-by: Rita Zhang <[email protected]> Co-authored-by: Sertaç Özercan <[email protected]>
…iguration Signed-off-by: wlee <[email protected]>
…iguration
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #3038
Special notes for your reviewer: