Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pointing to correct versioned yaml on website creation #3258

Merged

Conversation

JaydipGabani
Copy link
Contributor

What this PR does / why we need it:
Correctly updates the install command to point to appropriate versions in website.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.14%. Comparing base (6d1e4ee) to head (ea2b9dc).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3258      +/-   ##
==========================================
- Coverage   54.28%   54.14%   -0.15%     
==========================================
  Files         134      134              
  Lines       12356    10253    -2103     
==========================================
- Hits         6707     5551    -1156     
+ Misses       5152     4196     -956     
- Partials      497      506       +9     
Flag Coverage Δ
unittests 54.14% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaydipGabani
Copy link
Contributor Author

@ritazh @maxsmythe @sozercan This change sould now handle patching docs for subsequent minor release patches as well.

Copy link
Member

@sozercan sozercan Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to avoid a second pr? why can't we do this in the same pr for the beta release?

Copy link
Contributor Author

@JaydipGabani JaydipGabani Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the beta PR only gets released on a new minor version release, and docs changes are included with that. However, the patch-doc workflow is specifically for subsequent patch versions for which we do not update beta.

Makefile Outdated Show resolved Hide resolved
Signed-off-by: Jaydip Gabani <[email protected]>
@JaydipGabani
Copy link
Contributor Author

@sozercan are we good to merge this?

@JaydipGabani JaydipGabani merged commit f3caab2 into open-policy-agent:master Feb 28, 2024
16 checks passed
@JaydipGabani JaydipGabani deleted the fix-version-install branch February 28, 2024 19:09
leewoobin789 pushed a commit to softlee-io/gatekeeper that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants