fix: Remove validation of constraint template rego #3262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohammad Zuber Khan <[email protected]>
mzkhan
force-pushed
the
remove_validate_template_rego
branch
from
ba2304f
to
43f33c9
Compare
JaydipGabani
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3262 +/- ##
==========================================
+ Coverage 54.49% 54.52% +0.02%
==========================================
Files 134 134
Lines 12329 12318 -11
==========================================
- Hits 6719 6716 -3
+ Misses 5117 5107 -10
- Partials 493 495 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@mzkhan can you fix the linting error? the change looks good to me. |
sozercan
reviewed
Feb 12, 2024
|
Minor comment, otherwise LGTM |
maxsmythe
approved these changes
Feb 13, 2024
Signed-off-by: Mohammad Zuber Khan <[email protected]>
leewoobin789
pushed a commit
to softlee-io/gatekeeper
that referenced
this pull request
Apr 1, 2024
…#3262) Signed-off-by: Mohammad Zuber Khan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removing the flag to validate rego in constraint template.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #3027