Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update unit test for vap generation; add custom assets for envtest #3289

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Feb 27, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #3274

Special notes for your reviewer:

@ritazh ritazh requested a review from a team as a code owner February 27, 2024 20:11
@ritazh ritazh changed the title update unit test for vap generation; add custom assets for envtest fix: update unit test for vap generation; add custom assets for envtest Feb 27, 2024
Makefile Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.22%. Comparing base (6d1e4ee) to head (8571aa5).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3289      +/-   ##
==========================================
- Coverage   54.28%   54.22%   -0.06%     
==========================================
  Files         134      134              
  Lines       12356    10253    -2103     
==========================================
- Hits         6707     5560    -1147     
+ Misses       5152     4189     -963     
- Partials      497      504       +7     
Flag Coverage Δ
unittests 54.22% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit 6e2dba5 into open-policy-agent:master Feb 29, 2024
16 checks passed
@ritazh ritazh deleted the vap-ut branch February 29, 2024 15:15
leewoobin789 pushed a commit to softlee-io/gatekeeper that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update unit test for vap generation once the feature is more stable in k/k
4 participants