Fix incorrect index offsets in generateTargetingImage #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 63a9aa5 reworked the index generation code, inadvertently replacing a fixed offset of 6 * quad with a dynamic 8 * quad. Use the correct 6 * code multiplier with the new dynamic associationTypes count code. Verified to fix #173 on a Blackbird test box. Signed-off-by: Timothy Pearson <[email protected]>
|
On further analysis this is not the right repair, though it does modify the symptoms. Working on a proper fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 63a9aa5 reworked the index generation code, inadvertently
replacing a fixed offset of 6 * quad with a dynamic 8 * quad.
Use the correct 6 * code multiplier with the new dynamic
associationTypes count code.
Verified to fix #173 on a Blackbird test box.
Signed-off-by: Timothy Pearson [email protected]