From 7abfc103656a7b779bd1d4ee6267f481d6121dd9 Mon Sep 17 00:00:00 2001 From: Tigran Najaryan Date: Thu, 11 Jan 2024 12:52:23 -0500 Subject: [PATCH] Add one more example --- docs/resource/README.md | 2 +- model/resource/service_experimental.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/resource/README.md b/docs/resource/README.md index 72268ab8c7..68c86a6635 100644 --- a/docs/resource/README.md +++ b/docs/resource/README.md @@ -101,7 +101,7 @@ as specified in the [Resource SDK specification](https://github.com/open-telemet |---|---|---|---|---| | `service.instance.id` | string | The string ID of the service instance. [1] | `my-k8s-pod-deployment-1`; `627cc493-f310-47de-96bd-71410b7dec09` | Recommended | | `service.namespace` | string | A namespace for `service.name`. [2] | `Shop` | Recommended | -| `service.type` | string | The service type in reverse domain name notation. [3] | `io.opentelemetry.collector`; `io.redis`; `org.apache.kafka` | Recommended | +| `service.type` | string | The service type in reverse domain name notation. [3] | `io.opentelemetry.collector`; `io.redis`; `org.apache.kafka`; `com.yourcompany.productname` | Recommended | **[1]:** MUST be unique for each instance of the same `service.namespace,service.name` pair (in other words `service.namespace,service.name,service.instance.id` triplet MUST be globally unique). The ID helps to distinguish instances of the same service that exist at the same time (e.g. instances of a horizontally scaled service). It is preferable for the ID to be persistent and stay the same for the lifetime of the service instance, however it is acceptable that the ID is ephemeral and changes during important lifetime events for the service (e.g. service restarts). If the service has no inherent unique ID that can be used as the value of this attribute it is recommended to generate a random Version 1 or Version 4 RFC 4122 UUID (services aiming for reproducible UUIDs may also use Version 5, see RFC 4122 for more recommendations). diff --git a/model/resource/service_experimental.yaml b/model/resource/service_experimental.yaml index e599f84b95..e16b308abf 100644 --- a/model/resource/service_experimental.yaml +++ b/model/resource/service_experimental.yaml @@ -46,4 +46,4 @@ groups: will typically have a distinct `service.name` to help identify the logical role of the particular deployment, however their `service.type` will be the same and will help identify the deployed product. - examples: ["io.opentelemetry.collector", "io.redis", "org.apache.kafka"] + examples: ["io.opentelemetry.collector", "io.redis", "org.apache.kafka", "com.yourcompany.productname"]