Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading variable names: Coal #52

Open
felixfrischmuth opened this issue Jun 16, 2020 · 4 comments
Open

Misleading variable names: Coal #52

felixfrischmuth opened this issue Jun 16, 2020 · 4 comments

Comments

@felixfrischmuth
Copy link

When checking the nomenclature with our model output, I got two warnings. This leads me to this issue.
In the nomenclature (nomenclature/nomenclature/definitions/variable/technology/technologies.yaml) is the differentiation between "Coal” and "Lignite". I would suggest differing between „Hard Coal“ and „Lignite“, and maybe “Coal” for sum them up.
In nomenclature (nomenclature/nomenclature/definitions/variable/energy/...) there is only the variable "Coal". It should also include "Lignite" and "Hard coal", e.g. Secondary Energy|Electricity|Lignite.
If you think this too, I can do a pull request?

@tburandt
Copy link
Contributor

I support the suggestion of @felixfrischmuth to add the different subtypes of coal and provide a uniform way of handling it. So, I would propose to also add "Coal" for summing up the secondary energy variables as well as the technology variables.

E.g.:

Secondary Energy|Electricity|Coal
Secondary Energy|Electricity|Coal|Lignite
Secondary Energy|Electricity|Coal|Hard coal

and

Capacity|Electricity|Coal
Capacity|Electricity|Coal|Lignite
Capacity|Electricity|Coal|Hard coal

but of course for all related variables

@arght
Copy link
Collaborator

arght commented Jun 16, 2020

In that regard we may also add bituminous and sub-bituminous coal if anybody is willing to use them

@sandrinecharousset
Copy link
Collaborator

I support the suggestion of @felixfrischmuth to add the different subtypes of coal and provide a uniform way of handling it. So, I would propose to also add "Coal" for summing up the secondary energy variables as well as the technology variables.

E.g.:

Secondary Energy|Electricity|Coal
Secondary Energy|Electricity|Coal|Lignite
Secondary Energy|Electricity|Coal|Hard coal

and

Capacity|Electricity|Coal
Capacity|Electricity|Coal|Lignite
Capacity|Electricity|Coal|Hard coal

but of course for all related variables

I agree :-)

@danielhuppmann
Copy link
Member

I also agree with this suggestion (in the sub-category format of Coal as suggested by @tburandt)!

@felixfrischmuth if you need this urgently, please go ahead and start a PR - otherwise, it might make more sense to wait until I make a PR to implement a generic identifier (see #29), so that you don't have to add the coal disagggregation for every fuel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants