Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avro/Cytoband and core/Cytoband - do we need both? #180

Open
julie-sullivan opened this issue Mar 19, 2020 · 1 comment
Open

avro/Cytoband and core/Cytoband - do we need both? #180

julie-sullivan opened this issue Mar 19, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@julie-sullivan
Copy link
Contributor

// avro
   private java.lang.String chromosome;
   private java.lang.String stain;
   private java.lang.String name;
   private java.lang.Integer start;
   private java.lang.Integer end;
// core
	private String name;
	private String stain;
	private int start;
	private int end;

REST and the variant calculator use the avro one, and the chromosome collection seems to use the one from core.

@julie-sullivan
Copy link
Contributor Author

variantannotation is in avro, needs to be in avro and needs a cytoband.

So we should delete the core cytoband as a duplicate, and keep the avro one.

@imedina imedina self-assigned this Mar 20, 2020
@imedina imedina added this to the v2.0.0 milestone Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants