various cleanup items for the examples.

[hyposcaler-bot]

Ran thru all the examples to try them out found a few that needed some minor fixes to make them work, some of the issues were common across multiple labs.

Lot image references needed updating, for all the docker compose and containerlab examples, I updated references to official public images, or used same references from other labs

In all

replaced: gnmic:0.0.0
with: ghcr.io/openconfig/gnmic:latest

replaced: consul:latest
with: hashicorp/consul:latest

relaced: gnmic:0.0.0
with: ghcr.io/openconfig/gnmic:latest

replaced: quay.io/cortexproject/cortex:latest
with: quay.io/cortexproject/cortex:v1.18.1

not all the gnmic config files for cluster have api-server configured.

Used

+api-server:
+  enable-metrics: true

To keep failures out of the prom targets. For much the same reason, I also made references to services (as needed for the labs) explicit in the consul_sd_configs config.

i.e.

+        services:
+          - prometheus-prom-output-js
+          - prometheus-prom-output-nats
+          - prometheus-prom-output-oc
+          - prometheus-prom-output-redis

Fixed typo in value for env var GNMIC_OUTPUTS_OUTPUT1_LISTEN

-        GNMIC_OUTPUTS_OUTPUT1_LISTEN: clab-glab23-gnmic1:9804
+        GNMIC_OUTPUTS_OUTPUT1_LISTEN: clab-lab23-gnmic1:9804

For examples/deployments/3.pipelines/2.gnmic-nats-gnmic-influxdb/containerlab, corrected the datasource provided for grafana, was prom, replaced it with an influxDB.

For examples/deployments/3.pipelines/3a.gnmic-cluster-nats-gnmic-prometheus/containerlab & examples/deployments/3.pipelines/3b.gnmic-cluster-nats-gnmic-cluster-prometheus/containerlab

The gnmic-relay node needed some love in both labs, had a few issues resulting from collector config being copy pasted, and used a type of "input" for the configured input, should be nats.

Prom scrape configs referenced wrong lab in one case.

I have a branch with fixes, @karimra you OK with just one big PR for these?

[karimra]

Sounds reasonable, go for it. Thanks for doing that.

[hyposcaler-bot]

#552 is out.

Sounds reasonable, go for it. Thanks for doing that.

No worries, learned a lot, it was worth it.