fix(rate-limit): use the value of an object key, instead of the key itself #7877
+141
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
rikukissa
approved these changes
Oct 30, 2024
naftis
force-pushed
the
improve-rate-limit-tests
branch
from
e59435e
to
7229165
Compare
naftis
changed the title
naftis
changed the title
|
Your environment is deployed to https://improve-rate-limit-tests.opencrvs.dev |
naftis
force-pushed
the
improve-rate-limit-tests
branch
from
d8e6bc6
to
4796210
Compare
rikukissa
approved these changes
Oct 31, 2024
naftis
added a commit
that referenced
this pull request
Oct 31, 2024
…tself (#7877) * feat(tests): add rate limiting tests for multiple users * fix: ratelimiting using 'username' as key instead of the actual username * fix: add other tests back * fix: do a full object access like the function supports * chore(changelog): amend for 1.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this payload to
/auth/authenticatethe cached rate-limiting key was
username:/auth/authenticate.It's supposed to be
test.user:/auth/authenticate.