From 977fff87be2ac8ac2c871a9608a2b47ec9c5d272 Mon Sep 17 00:00:00 2001 From: jamil314 Date: Thu, 31 Oct 2024 19:48:26 +0600 Subject: [PATCH 1/2] fix: continue on error so that screeenshots are uploaded --- .github/workflows/deploy-and-e2e.yml | 1 + .github/workflows/e2e.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/deploy-and-e2e.yml b/.github/workflows/deploy-and-e2e.yml index 4aa89ccf1..68f1940b9 100644 --- a/.github/workflows/deploy-and-e2e.yml +++ b/.github/workflows/deploy-and-e2e.yml @@ -134,6 +134,7 @@ jobs: run: npx playwright test ./e2e/testcases/${{ matrix.test_dir }} env: DOMAIN: '${{ vars.DOMAIN }}' + continue-on-error: true - uses: actions/upload-artifact@v4 if: steps.check-specs.outputs.has_spec_files == 'true' diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index bbe1bf3da..ced139799 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -91,6 +91,7 @@ jobs: run: npx playwright test ./e2e/testcases/${{ matrix.test_dir }} env: DOMAIN: '${{ vars.DOMAIN }}' + continue-on-error: true - uses: actions/upload-artifact@v4 if: steps.check-specs.outputs.has_spec_files == 'true' From 504fd107799978b9b27688f56f2f5a99f0e1f5d3 Mon Sep 17 00:00:00 2001 From: jamil314 Date: Thu, 31 Oct 2024 19:55:30 +0600 Subject: [PATCH 2/2] e2e: retry on CI --- playwright.config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/playwright.config.ts b/playwright.config.ts index 1ea7d2b61..18685d401 100644 --- a/playwright.config.ts +++ b/playwright.config.ts @@ -16,7 +16,7 @@ export default defineConfig({ /* Fail the build on CI if you accidentally left test.only in the source code. */ forbidOnly: !!process.env.CI, /* Retry on CI only */ - retries: 0, + retries: process.env.CI ? 2 : 0, /* Opt out of parallel tests on CI. */ workers: process.env.CI ? 1 : undefined, /* Reporter to use. See https://playwright.dev/docs/test-reporters */