Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests depend on skopeo now #4

Open
michaelsauter opened this issue Feb 21, 2023 · 4 comments
Open

Tests depend on skopeo now #4

michaelsauter opened this issue Feb 21, 2023 · 4 comments

Comments

@michaelsauter
Copy link
Member

https://github.com/opendevstack/ods-pipeline/blob/master/test/tasks/ods-package-image_test.go#L130 introduces a dependency on skopeo. This is currently not covered by make check-system. We either need to add it there, or find a way to do the check without skopeo. I would prefer the latter if possible (using docker may work, which is already required).

FYI @henrjk Thoughts?

@henrjk
Copy link
Member

henrjk commented Mar 17, 2023

I will try whether this can be done with docker.

@henrjk
Copy link
Member

henrjk commented Mar 17, 2023

I spotted another usage of skopeo:

https://github.com/opendevstack/ods-pipeline/blob/ca46bcb944f2a9c108324b15148f156112caf2b0/test/tasks/ods-deploy-helm_external_test.go#L124

@michaelsauter
Copy link
Member Author

Transferring as a consequence of opendevstack/ods-pipeline#722.

@michaelsauter michaelsauter transferred this issue from opendevstack/ods-pipeline Sep 29, 2023
@henrjk
Copy link
Member

henrjk commented Oct 26, 2023

I am not sure where one would add a local system check to also include skopeo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants