Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/remove local skopeo dependency #681

Closed
wants to merge 3 commits into from

Conversation

henrjk
Copy link
Member

@henrjk henrjk commented Mar 17, 2023

At the moment this does not work, but I am not sure why.
Tag related commands from log excerpt gh-issue-662-docker-tags-not-working.log:

INFO  | skopeo copy docker://kind-registry.kind:5000/npjhnsyo/workspace-280637196:3cd3a01e4f8924ae17e4273543b5d6739ce3dc32 docker://kind-registry.kind:5000/npjhnsyo/workspace-280637196:latest

INFO  | skopeo copy docker://kind-registry.kind:5000/npjhnsyo/workspace-280637196:3cd3a01e4f8924ae17e4273543b5d6739ce3dc32 docker://kind-registry.kind:5000/npjhnsyo/workspace-280637196:cool

And then the local test command:

ods-package-image_test.go:143: docker [inspect --format={{.RepoTags}} localhost:5000/npjhnsyo/workspace-280637196:3cd3a01e4f8924ae17e4273543b5d6739ce3dc32]: exit status 1

exit status 1 means that the image is not found.

Now when I comment out the checkTags invocation, run the test and then locally issue the command it does find the image and associated manifest:

$docker inspect --format={{.RepoTags}} localhost:5000/lmxlhpwy/workspace-2456216427:3507037f00154c62410142e770df87fbed35db20
[localhost:5000/lmxlhpwy/workspace-2456216427:3507037f00154c62410142e770df87fbed35db20 localhost:5000/lmxlhpwy/workspace-2456216427:cool localhost:5000/lmxlhpwy/workspace-2456216427:latest]

Closes opendevstack/ods-pipeline-image#4

Tasks:

  • Updated design documents in docs/design directory or not applicable
  • Updated user-facing documentation in docs directory or not applicable
  • Ran tests (e.g. make test) or not applicable
  • Updated changelog or not applicable
  • [ ]

@michaelsauter
Copy link
Member

michaelsauter commented Sep 29, 2023

Closing as a consequence of #722. Unfortunately PRs cannot be transferred so a similar PR would need to be opened in ods-pipeline-image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests depend on skopeo now
2 participants