Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the edx-token-utils dependency #36009

Open
1 task
feanil opened this issue Dec 11, 2024 · 0 comments
Open
1 task

Drop the edx-token-utils dependency #36009

feanil opened this issue Dec 11, 2024 · 0 comments
Labels
code health Proactive technical investment via refactorings, removals, etc. good first issue A good task for a newcomer to start with maintenance Routine upkeep necessary for the health of the platform

Comments

@feanil
Copy link
Contributor

feanil commented Dec 11, 2024

Context

Currently the edx-platform repo depends on the edx-token-utils package, that package lives in the edx org and not in the openedx org. From what I can tell, the edx-platform only uses one function which looks like it's a thin wrapper around pyjwkest.

  • edx-token-utils is a library created to handle non-auth-related JWTs, which edx-exams introduced to validate exam-related JWTs.
  • This PR is where Zach introduced edx-token-utils into edx-platform for use with edx-exams: feat: gate exam content using access token #31653.

Given the simplicity of the functions and the lack of use anywhere else, I think it makes the most sense to just fold in the necessary parts into edx-platform and drop the dependency.

Acceptance Criteria

  • edx-platform has no dependencies on edx-token-utils

Implementation Notes

This library is also referenced in the edx-exams repo maintained by 2U in the edx github org. If the code is folded in here, then it would be good to have a comment to indicate the specification it's following and where to find that specification.

@feanil feanil added maintenance Routine upkeep necessary for the health of the platform code health Proactive technical investment via refactorings, removals, etc. good first issue A good task for a newcomer to start with labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Proactive technical investment via refactorings, removals, etc. good first issue A good task for a newcomer to start with maintenance Routine upkeep necessary for the health of the platform
Projects
None yet
Development

No branches or pull requests

1 participant