From 28eac43a584d681daac2c2bf02f29f375252cf7b Mon Sep 17 00:00:00 2001
From: Francisco Ribeiro <fr@franciscoribeiro.net>
Date: Tue, 8 Oct 2024 09:19:13 +0100
Subject: [PATCH] EWPP-4578: Fix banner and carousel kernel tests rendering.

---
 oe_theme.theme                                      | 10 +++++-----
 tests/src/Kernel/Paragraphs/MediaParagraphsTest.php |  4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/oe_theme.theme b/oe_theme.theme
index 96701bc67..1628990b2 100644
--- a/oe_theme.theme
+++ b/oe_theme.theme
@@ -1705,15 +1705,15 @@ function oe_theme_preprocess_paragraph__oe_banner(array &$variables): void {
  * @return array
  *   Returns sources and fallback url.
  */
-function _oe_theme_load_from_responsive_image_style_id($responsive_image_style_id, $uri) {
+function _oe_theme_load_from_responsive_image_style_id(string $responsive_image_style_id, string $uri):array {
   $responsive_image_style = ResponsiveImageStyle::load($responsive_image_style_id);
-  $resp_image = [];
+  $responsive_image_generator = [];
   $breakpoints = array_reverse(\Drupal::service('breakpoint.manager')->getBreakpointsByGroup($responsive_image_style->getBreakpointGroup()));
   foreach ($responsive_image_style->getKeyedImageStyleMappings() as $breakpoint_id => $multipliers) {
     if (isset($breakpoints[$breakpoint_id])) {
       $responsive_image = _responsive_image_build_source_attributes(['uri' => $uri], $breakpoints[$breakpoint_id], $multipliers);
       $responsive_image_array = $responsive_image->toArray();
-      $resp_image['sources'][] = [
+      $responsive_image_generator['sources'][] = [
         'src' => $responsive_image_array['srcset'],
         'media' => $responsive_image_array['media'] ?? '',
       ];
@@ -1721,9 +1721,9 @@ function _oe_theme_load_from_responsive_image_style_id($responsive_image_style_i
   }
 
   // Add fallback style.
-  $resp_image['fallback'] = _responsive_image_image_style_url($responsive_image_style->getFallbackImageStyle(), $uri);
+  $responsive_image_generator['fallback'] = _responsive_image_image_style_url($responsive_image_style->getFallbackImageStyle(), $uri);
 
-  return $resp_image;
+  return $responsive_image_generator;
 }
 
 /**
diff --git a/tests/src/Kernel/Paragraphs/MediaParagraphsTest.php b/tests/src/Kernel/Paragraphs/MediaParagraphsTest.php
index 1bb102955..ce47efe5d 100644
--- a/tests/src/Kernel/Paragraphs/MediaParagraphsTest.php
+++ b/tests/src/Kernel/Paragraphs/MediaParagraphsTest.php
@@ -450,8 +450,8 @@ public function testTextWithMedia(): void {
    */
   public function testBanner(): void {
 
-    $breakpointsByGroup = \Drupal::service('breakpoint.manager')->getBreakpointsByGroup('oe_theme');
-    $this->assertCount(5, $breakpointsByGroup);
+    $breakpoints_by_group = \Drupal::service('breakpoint.manager')->getBreakpointsByGroup('oe_theme');
+    $this->assertCount(5, $breakpoints_by_group);
 
     // Set image media translatable.
     $this->container->get('content_translation.manager')->setEnabled('media', 'image', TRUE);