Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Use twig filter extension for Image value object #216

Open
msnassar opened this issue Mar 24, 2023 · 2 comments
Open

Proposal: Use twig filter extension for Image value object #216

msnassar opened this issue Mar 24, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@msnassar
Copy link

Backgroup:
Currently, in order to pass ImageValueObject to a pattern, you are doing preprocess to prepare the image e.g. here. I think, this is very complex and requires to do preprocess for each entity type and each image field!

Solution:
To avoid all these preprocesses, I suggest to create a twig extension that converts a render array that contains ImageItem to ImageValueObject.

Example from UCPKN:
Find the extension here
Find usages example here

Please let me know your thoughts?

@tibi2303
Copy link
Contributor

Good day,

Can i have access to ucpkn repo in order to see the examples?

@msnassar
Copy link
Author

@tibi2303 Sorry, I do not have the privileges to grant the access. I recommend to contact QA team...

@brummbar brummbar added the enhancement New feature or request label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants