Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AbstractTest extendable #149

Open
claudiu-cristea opened this issue Feb 18, 2021 · 0 comments
Open

Make AbstractTest extendable #149

claudiu-cristea opened this issue Feb 18, 2021 · 0 comments

Comments

@claudiu-cristea
Copy link
Contributor

Problem

If a 3rd party, providing task runner commands, wants to extend \OpenEuropa\TaskRunner\Tests\AbstractTest, it cannot reuse most of its methods, such as ::getClassLoader(), ::getFixtureContent(), ::getSandboxRoot(), because they are hardcoding paths. But when openeuropa/task-runner is a dependency, under vendor/, the paths are no more correct.

For instance, the https://github.com/openeuropa/task-runner-changelog project had to override those methods, see https://github.com/openeuropa/task-runner-changelog/blob/bd01ccdf17fe7f9fe8465188d9f0cd7a1f219684/tests/ChangelogCommandTest.php, in order to reuse AbstractTest.

Proposal

Make \OpenEuropa\TaskRunner\Tests\AbstractTest methods inheritable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant