Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-namespace support to Secrets CRUD tests #67

Closed
LucasRoesler opened this issue Apr 18, 2021 · 0 comments · Fixed by #79
Closed

Add multi-namespace support to Secrets CRUD tests #67

LucasRoesler opened this issue Apr 18, 2021 · 0 comments · Fixed by #79

Comments

@LucasRoesler
Copy link
Member

Refactor the test cases in the secretCRUD_test.go to use the same table driven test pattern introduced in #66 so that we can run the tests in the default "empty" namespace and a non-default namespace when it is configured.

Part of #61

LucasRoesler added a commit to LucasRoesler/certifier that referenced this issue Oct 17, 2021
- Add multinamespace configuration to the secrets, refactoring to use a
  test table.
- Update to the latest faas-provider
- Add test for raw value support

**Notes**
- the new RawValue support in faas-netes is broken, it does not support Update yet

**Testing**

```sh
kind create cluster

arkade install openfaas --basic-auth=false --clusterrole

kubectl create namespace certifier-test
kubectl annotate namespace/certifier-test openfaas="1"

export CERTIFIER_NAMESPACES=certifier-test

kubectl port-forward -n openfaas svc/gateway 8080:8080 &
make test-kubernetes
```

Resolves openfaas#67
Closes openfaas#74

Signed-off-by: Lucas Roesler <[email protected]>
LucasRoesler added a commit to LucasRoesler/certifier that referenced this issue Oct 17, 2021
- Add multinamespace configuration to the secrets, refactoring to use a
  test table.
- Update to the latest faas-provider
- Add test for raw value support

**Notes**
- the new RawValue support in faas-netes is broken, it does not support Update yet

**Testing**

```sh
kind create cluster

arkade install openfaas --basic-auth=false --clusterrole

kubectl create namespace certifier-test
kubectl annotate namespace/certifier-test openfaas="1"

export CERTIFIER_NAMESPACES=certifier-test

kubectl port-forward -n openfaas svc/gateway 8080:8080 &
make test-kubernetes
```

Resolves openfaas#67
Closes openfaas#74

Signed-off-by: Lucas Roesler <[email protected]>
alexellis pushed a commit that referenced this issue Nov 24, 2021
- Add multinamespace configuration to the secrets, refactoring to use a
  test table.
- Update to the latest faas-provider
- Add test for raw value support

**Notes**
- the new RawValue support in faas-netes is broken, it does not support Update yet

**Testing**

```sh
kind create cluster

arkade install openfaas --basic-auth=false --clusterrole

kubectl create namespace certifier-test
kubectl annotate namespace/certifier-test openfaas="1"

export CERTIFIER_NAMESPACES=certifier-test

kubectl port-forward -n openfaas svc/gateway 8080:8080 &
make test-kubernetes
```

Resolves #67
Closes #74

Signed-off-by: Lucas Roesler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant