feat: uses moby to generate human friendly name for store #121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the moby (docker reference) names generator to give name to stores.
Previously, the
--name
flag was enforced by a check on thecreateStoreWithModel
function, ensuring that the storeName would never be empty and preventing the generation of a name. As a result, attempting to create a store without specifying a name resulted in an error:To address this issue, the verification for the
--name
flag was removed.It aims to close #115 issue
A new dependency has been introduced to the project. If adding a new dependency is undesirable, it is possible to incorporate the relevant code directly into this codebase since it is a simple piece of code. :)
References
#115
Review Checklist
main