Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pb with duplicated families/individuals when building ERFS_FPR in 2013 #182

Open
elie-gerschel opened this issue Dec 19, 2019 · 1 comment

Comments

@elie-gerschel
Copy link
Contributor

Hi there!

I really enjoy OpenFisca-France-Data, but I recently encountered an issue.

Here is what I did:

survey_scenario = get_survey_scenario(
tax_benefit_system = tax_benefit_system,
year = 2013,
rebuild_input_data = True,
)

The traceback is below. I have put a temporary fix (dropping families which were duplicated) in 2013 and could see the same kind of fix had been implemented already for one family.
The issue deserves some investigation.

Here is the traceback

Traceback (most recent call last):

File "", line 24, in
rebuild_input_data = True,

File "C:\Users\elieg\openfisca-france-data\openfisca_france_data\erfs_fpr\get_survey_scenario.py", line 86, in get_survey_scenario
use_marginal_tax_rate = use_marginal_tax_rate,

File "C:\Users\elieg\Anaconda3\envs\ipp\lib\site-packages\openfisca_survey_manager\scenarios.py", line 791, in init_from_data
self.build_input_data(year = data_year)

File "C:\Users\elieg\openfisca-france-data\openfisca_france_data\erfs_fpr\scenario.py", line 72, in build_input_data
build(year = year)

File "C:\Users\elieg\openfisca-france-data\openfisca_france_data\erfs_fpr\input_data_builder_init_.py", line 50, in build
famille.build_famille(year = year)

File "C:\Users\elieg\Anaconda3\envs\ipp\lib\site-packages\openfisca_survey_manager\temporary.py", line 39, in func_wrapper
return func(*args, temporary_store = temporary_store, **kwargs)

File "C:\Users\elieg\openfisca-france-data\openfisca_france_data\erfs_fpr\input_data_builder\step_04_famille.py", line 98, in build_famille
skip_enfants_a_naitre = skip_enfants_a_naitre)

File "C:\Users\elieg\openfisca-france-data\openfisca_france_data\erfs_fpr\input_data_builder\step_04_famille.py", line 138, in create_familles
year = year,

File "C:\Users\elieg\openfisca-france-data\openfisca_france_data\erfs_fpr\input_data_builder\step_04_famille.py", line 675, in famille_5
assert not famille.noindiv.duplicated().any()

AssertionError

Context

I identify more as a:

  • Economist (I make microsimulations with real populations).
  • Developer (I create tools that use OpenFisca-France-Data).
  • Commenter (I make data visualisations).
  • LexImpact (I model reforms to make them exist).

(remove this line as well as all items in the list that don't fit your situation)

@bonjourmauko
Copy link
Member

Hi @elie-gerschel thanks for reporting this issue. I'm not a Windows user myself but maybe @benjello, @claireleroy or @openfisca/france-contrib-ipp have already encountered this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants