-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add support for HMR with virtual sites #1056
Comments
The discussion on this specific behavior when I first implemented it was in Slack, so it ought to be brought out into the public anyway This is one of the many cases in which we talk about being super general and flexible and xyz but when the rubber hits the road, we really only care about a finite set of use cases. The headache is at the intersection of virtual sites, HMR, and whether or not water is rigid. It gets much simpler to think about if you skip waters when applying HMR, which are probably already rigid if the use case calls for HMR. We also have comments from Shirts and Gilson that (presumably on ligands) HMR with virtual sites should generally be okay. I basically buy this, since HMR shouldn't interact directly with the virtual sites. Even though I know you're only using OPC and don't have virtual sites on ligand/protein/solvent, I want to be methodical in removing this restriction. #1055 should hold us over for a little bit, but after that I want to make sure I can run a ligand (with virtual site parameters and HMR) in OPC water without things blowing up. Tests should also make sure
|
Description
I notice the wording is "not yet":
openff-interchange/openff/interchange/interop/openmm/__init__.py
Line 186 in 57dd53a
I also don't seem to see any open issues, so erm.. here's an issue for it 🙃
The text was updated successfully, but these errors were encountered: