Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Hot-Reloading Feature for Config Files in OpenIM-Server with Viper #1506

Closed
2 tasks done
cubxxw opened this issue Nov 30, 2023 · 8 comments
Closed
2 tasks done
Labels
feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Milestone

Comments

@cubxxw
Copy link
Contributor

cubxxw commented Nov 30, 2023

Checklist

  • I've searched for similar issues and couldn't find anything matching
  • I've discussed this feature request in the OpenIMSDK Slack and got positive feedback

Is this feature request related to a problem?

None

Problem Description

The OpenIM server currently utilizes Viper for configuration file parsing. While this is effective for initial loading, it lacks the ability to dynamically reload configurations at runtime.

Solution Description

Implement hot-reloading functionality in OpenIM server. This will allow the server to update configurations in real-time without needing a restart, whenever changes are made to the config files.

Benefits

  1. Reduced Downtime: Eliminates the need to restart the server for config changes.
  2. Improved Efficiency: Facilitates quick updates and testing of new configurations.
  3. Dynamic Configuration Management: Offers more flexibility in managing server settings.

Potential Drawbacks

no

Additional Information

Potential challenges in implementing hot-reloading with Viper.
Implications for current server performance and stability.
Best practices for managing and deploying configuration changes in a live environment.

@cubxxw cubxxw added feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Nov 30, 2023
@kubbot
Copy link
Contributor

kubbot commented Nov 30, 2023

This issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨
Join slack 🤖 to connect and communicate with our developers.
If you wish to accept this assignment, please leave a comment in the comments section: /accept.🎯

@cubxxw cubxxw added this to the v3.6 milestone Nov 30, 2023
@charles-chenzz
Copy link
Contributor

/accept

@cubxxw
Copy link
Contributor Author

cubxxw commented Nov 30, 2023

Thank you for accepting this PR. I will closely follow your repository at https://github.com/charles-chenzz/open-im-server. It would be even more friendly if interested individuals could provide their input.
At the same time, I kindly request that you submit a PR as soon as possible to facilitate our progress.

@kubbot
Copy link
Contributor

kubbot commented Jan 30, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@charles-chenzz
Copy link
Contributor

please remove my repo link. Thanks
/close

@charles-chenzz charles-chenzz removed their assignment Feb 6, 2024
@Lansongxx
Copy link

/accept

@cubxxw
Copy link
Contributor Author

cubxxw commented Apr 1, 2024

@Lansongxx This one does not support contributor participation for the time being, this one has been claimed by a contributor @charles-chenzz

Check out the issue below if you're interested

#2099

Or you can see that there are other features to try.

Or you can create your own issue

~ thx

@kubbot
Copy link
Contributor

kubbot commented Jul 1, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
Status: Done
Development

No branches or pull requests

5 participants