Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Other]: Direct Conversation Clearing Causes Read Status Update Issue #2374

Open
zhaolibo1989 opened this issue Jun 28, 2024 · 1 comment
Open
Labels
other Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@zhaolibo1989
Copy link
Contributor

What would you like to share?

Before marking the conversation as read (MarkConversationAsRead) or marking the messages as read (MarkMsgsAsRead), if the conversation is cleared directly (clearConversation), it will only set the read sequence number (HasReadSeq), but will not send a read receipt (HasReadReceipt). This will cause the read status of the message to not be updated, and the sender will always see the message as "unread" (is_read=false).
I am not sure if a read receipt should be sent here. If HasReadSeq represents the read position, meaning "I have read all messages up to this sequence number", then these unread messages should be marked as read (is_read=true). On the opposite, if reading requires explicitly using the "Mark as Read" interface, like MarkConversationAsRead and MarkMsgsAsRead, then directly clearing the conversation should not include the "Mark as Read" functionality.
So, when I clear the conversation directly before marking it as read, the sender of the message always sees the message as "unread," is this a issue?

Additional information

No response

@zhaolibo1989 zhaolibo1989 added the other Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 28, 2024
@zhaolibo1989
Copy link
Contributor Author

func: clearConversation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

1 participant