-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: BayesEoR: Bayesian 21-cm Power Spectrum Estimation from Interferometric Visibilities #6667
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🔴 Failed to discover a valid open source license |
@musoke, @zonca — This is the review thread for the paper. All of our correspondence will happen here from now on. Thanks again for agreeing to participate! 👉 Please read the "Reviewer instructions & questions" in the first comment above, and generate your checklists by commenting The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for the review process to be completed within about 4-6 weeks but please try to make a start ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. Please get your review started as soon as possible! |
@jburba — I should have caught this before, but it looks like your code is not licensed. You'll need to add an appropriate open source license before we can proceed. https://choosealicense.com can be a useful resource. |
Thanks @dfm , we forgot to add that. I've added a license to the repo. |
Review checklist for @musokeConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @zoncaConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@jburba I opened issues on the repository with some feedback, the only one which is blocking is PSims/BayesEoR#20, if you focus first on this issue, I can continue trying to run the example config. I was able to build the matrix stack, but cannot run sampling. |
@jburba @dfm finished my review and opened issues for follow-up on what I found, all linked in the review checklist. Once the issues are addressed (which doesn't necessarily mean we implement what I suggest, we could also agree something is a longer term goal), I think this is good for publication. Thanks! |
Thanks all! @musoke — I'd probably recommend that you see how far you can get with your review, as long as @zonca's issues aren't full blockers (it does seem like the installation one might be?). That way @jburba could work on addressing all the comments in parallel. Otherwise this could end up dragging on longer than we want. But you are all welcome to proceed as you feel is best for everyone involved! |
Good job @jburba, my review is finished, @musoke I think you can get started, you might want to check the 3 issues I left open in the repo to see if you feel those should be addressed before publication or not: https://github.com/PSims/BayesEoR/issues/created_by/zonca |
@musoke — Just a ping to make sure this is on your radar. Please revisit ASAP. Thank you! |
I have finished my review. Summary: it's a nice package but there are some outstanding issues to address.
|
Thank you. I completed my checklist |
@editorialbot set 10.5281/zenodo.13912275 as archive |
Done! archive is now 10.5281/zenodo.13912275 |
@editorialbot check references |
@editorialbot generate pdf |
|
@editorialbot recommend-accept |
|
|
👋 @openjournals/aass-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6087, then you can now move forward with accepting the submission by compiling again with the command |
@musoke, @zonca — Many thanks again for your reviews here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!! @jburba — I have now handed your paper off for a final review by the track editor @warrickball, who may have some final edits before publication. Thanks again for your patience! |
Hi @jburba — I've been quietly working through a few checks but I do apologise for the slightly slow response to this. I've opened a pull request with a few final editorial touches. With those implemented I'll test the metadata generation one more time then almost certainly be able to proceed with publication. |
Hi @warrickball , we've merged your pull request, thanks for the edits. If you need anything else from us please let us know! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/aass-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6152, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @jburba (Jacob Burba)
Repository: https://github.com/PSims/BayesEoR
Branch with paper.md (empty if default branch):
Version: 1.0.0
Editor: @dfm
Reviewers: @musoke, @zonca
Archive: 10.5281/zenodo.13912275
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@musoke & @zonca, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @dfm know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @musoke
📝 Checklist for @zonca
The text was updated successfully, but these errors were encountered: