Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WorkerSinkTask and WorkerSourceTask need to extract public methods and abstract them into a public parent class WorkerTask. #10

Open
odbozhou opened this issue Apr 22, 2019 · 0 comments
Open

WorkerSinkTask and WorkerSourceTask need to extract public methods and abstract them into a public parent class WorkerTask. #10

odbozhou opened this issue Apr 22, 2019 · 0 comments

Comments

@odbozhou
Copy link
Contributor

Both WorkerSinkTask and WorkerSourceTask are implemented runnable directly.
When getting some public properties of workerSinkTask or workerSourceTask, you must have instanceof runnable, which is bad.
So WorkerSinkTask and WorkerSourceTask need to extract public methods and abstract them into a public parent class WorkerTask.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@odbozhou