Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming inconsistency for evaluation measure #386

Open
HeidiSeibold opened this issue Aug 10, 2017 · 3 comments
Open

Naming inconsistency for evaluation measure #386

HeidiSeibold opened this issue Aug 10, 2017 · 3 comments

Comments

@HeidiSeibold
Copy link
Member

It is "predictive_accuracy" in

evals <- listOMLRunEvaluations(task.id = tsk.id, evaluation.measure = "predictive_accuracy")

but "predictive.accuracy" in

names(evals)

is that intentional?

@giuseppec
Copy link
Member

Hm. I see this is not user friendly. Reason is because R guys have their own naming convention (words in column names and function arguments are separated with dots).
Maybe allowing both is better better:

evals <- listOMLRunEvaluations(task.id = tsk.id, evaluation.measure = "predictive.accuracy")
evals <- listOMLRunEvaluations(task.id = tsk.id, evaluation.measure = "predictive_accuracy")

???

@berndbischl
Copy link
Contributor

i think it was a bad decision to rename stuff, from the OML naming scheme, to something else.
but that is not easy to change now.

I REALLY dont want to complicate things further by doing this :

Maybe allowing both is better better:

document this properly, and MAYBE later we remove the renaming completely.
but this will break some existing stuff.

@berndbischl
Copy link
Contributor

@giuseppec

can you please create a clean issue, and document which OML things we rename where?
then we can make an informed decision.
also stuff becomes more transpararent for all users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants