Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace test data with fictitious examples #42

Open
siwhitehouse opened this issue Nov 27, 2019 · 5 comments
Open

Replace test data with fictitious examples #42

siwhitehouse opened this issue Nov 27, 2019 · 5 comments

Comments

@siwhitehouse
Copy link

The current test data in https://github.com/openownership/lib-cove-bods/tree/master/tests/fixtures has examples of actual companies. In line with our other CoVE instances and the BODS standard website we should replace this test data with fictitious people and companies.

@siwhitehouse
Copy link
Author

This was copied across from Open Data Services' (internal) issue http://bods.opendataservices.coop/redmine/issues/563

@odscjames
Copy link
Collaborator

Can we be clear what data needs to be removed? Thanks.

Noting that a standard pull request will mean that the data will still be available in the usual git history. We can rewrite history to remove the data fully, but that will take much more time and cause issues for anyone else with checked out versions.

@stevenday
Copy link

Discussing this, it's just Chris Taggarts details, so we can just remove it now and not worry about the git rewrite.

@ScatteredInk
Copy link
Collaborator

@kd-ods
Copy link
Collaborator

kd-ods commented Jul 29, 2024

This will be removed for BODS 0.4 tests and beyond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants