Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count of previous statements that are referenced from replacesStatement and NOT in the dataset #46

Open
siwhitehouse opened this issue Dec 6, 2019 · 2 comments

Comments

@siwhitehouse
Copy link

There may be the following scenario:

Statement A [ MISSING ]
Statement B Replaces Statement A
Statement C Replaces Statement A, B

@odscjames raised the question of whether that data set is valid - should Statement C list A as well as B?

The docs are not clear on what the expected use of replacesStatement is in this case. @kd-ods suggested that we should require that Statement C lists both A and B, which would support the streaming API use case.

In relation to this particular statistical count, @kd-ods thinks the count should be 1. Naming this count 'Replaced statements missing from the dataset' would make that clearer.

@siwhitehouse
Copy link
Author

This was copied across from Open Data Sevices (internal) helpdesk issue http://bods.opendataservices.coop/redmine/issues/321

@kd-ods kd-ods transferred this issue from openownership/cove-bods Dec 17, 2019
@kd-ods
Copy link
Collaborator

kd-ods commented Jul 29, 2024

Various problems with replacesStatements as a way of capturing change over time led to it being retired after BODS version 0.4. This underspecification was just one of the problems.

It is imo not worth properly specifying a retired field in order to validate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants