From 15d3194c91e7c74d9386b4e5c18c6ddb114d1d38 Mon Sep 17 00:00:00 2001
From: carlosmondra <carlos@openreview.net>
Date: Fri, 27 Sep 2024 17:14:02 -0400
Subject: [PATCH] Fix/upload artifacts on failure (#2362)

* Feat: Upload artifacts on failure

* Chore: Force failure

* Fix: Change how when is called

* Chore: Change when artifacts are uploaded

* Chore: Remove force failure test
---
 .circleci/config.yml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 6e1c2956e..62fc07648 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -132,22 +132,24 @@ jobs:
           name: Run tests
           command: |
             cd ~/openreview-py-repo
+            mkdir test-reports
             pip install -U pytest
             pip install py
             pip install selenium
             pip install pytest-selenium
             pip install -e .
             TEST_FILES=$(circleci tests glob "tests/test_*.py" | circleci tests split --split-by=timings)
-            mkdir test-reports
             pytest --durations=0 --junitxml=test-reports/junit.xml --driver Firefox --driver-path tests/drivers/geckodriver $TEST_FILES
       - run:
           name: Copy API logs to artifacts
+          when: on_fail
           command: |
             cp ~/openreview/logs/* ~/openreview-py-repo/test-reports/
             cp ~/openreview-v2/logs/* ~/openreview-py-repo/test-reports/
       - store_test_results:
           path: test-reports
       - store_artifacts:
+          when: always
           path: test-reports
   deploy:
     working_directory: ~/openreview-py-repo