From 968db1fca0db95ba2cbd2149765f04fd1355a604 Mon Sep 17 00:00:00 2001 From: Jonathan Kummerfeld <1298052+jkkummerfeld@users.noreply.github.com> Date: Fri, 27 Sep 2024 04:48:54 +0800 Subject: [PATCH] Update ARR submission form (#2348) * Fixing ARR review form to have more space in answers * Activating markdown as well * Tweaks to ARR submission form requested by EICs * Remove A3 from submissions --------- Co-authored-by: Harold Rubio Co-authored-by: Harold Rubio <43583679+haroldrubio@users.noreply.github.com> Co-authored-by: celestemartinez <32438984+celestemartinez@users.noreply.github.com> --- openreview/stages/arr_content.py | 46 ++++++++++++-------------------- tests/test_arr_venue_v2.py | 3 --- 2 files changed, 17 insertions(+), 32 deletions(-) diff --git a/openreview/stages/arr_content.py b/openreview/stages/arr_content.py index 132e5c0f2..09a3e1716 100644 --- a/openreview/stages/arr_content.py +++ b/openreview/stages/arr_content.py @@ -388,7 +388,7 @@ "type": "string" } }, - "description": "Authors are required to discuss the limitations of their work in a dedicated section titled \"Limitations\". Papers without this section will be desk rejected. Please confirm that your paper has a limitations section by checking this box.", + "description": "Authors are required to discuss the limitations of their work in a dedicated section titled \"Limitations\" (not counting towards page limit). Papers without this section will be desk rejected. Please confirm that your paper has a limitations section by checking this box.\n\nThis question and those that follow are from the Responsible Research Checklist, please see this page for advice on filling it in: https://aclrollingreview.org/responsibleNLPresearch/", "order": 27 }, "A2_potential_risks": { @@ -403,7 +403,7 @@ "type": "string" } }, - "description": "Did you discuss any potential risks of your work? Note, this question, and those that follow, are from the Responsible Research Checklist (details here: https://aclrollingreview.org/responsibleNLPresearch/ )", + "description": "Did you discuss any potential risks of your work?", "order": 28 }, "A2_elaboration": { @@ -417,32 +417,6 @@ "description": "For yes, provide a section number. For no, justify why not.", "order": 29 }, - "A3_abstract_and_introduction_summarize_claims": { - "value": { - "param": { - "input": "radio", - "enum": [ - "Yes", - "No", - "N/A" - ], - "type": "string" - } - }, - "description": "Do the abstract and introduction summarize the paper's main claims?", - "order": 30 - }, - "A3_elaboration": { - "value": { - "param": { - "minLength": 1, - "optional": True, - "type": "string" - } - }, - "description": "For yes, provide a section number. For no, justify why not.", - "order": 31 - }, "B_use_or_create_scientific_artifacts": { "value": { "param": { @@ -717,7 +691,7 @@ "type": "string" } }, - "description": "If you used existing packages (e.g., for preprocessing, for normalization, or for evaluation), did you report the implementation, model, and parameter settings used (e.g., NLTK, Spacy, ROUGE, etc.)?", + "description": "If you used existing packages (e.g., for preprocessing, for normalization, or for evaluation, such as NLTK, SpaCy, ROUGE, etc.), did you report the implementation, model, and parameter settings used?", "order": 52 }, "C4_elaboration": { @@ -1060,6 +1034,8 @@ "param": { "minLength": 1, "optional": False, + "input": "textarea", + "markdown": True, "type": "string" } }, @@ -1071,6 +1047,8 @@ "param": { "minLength": 1, "optional": False, + "input": "textarea", + "markdown": True, "type": "string" } }, @@ -1082,6 +1060,8 @@ "param": { "minLength": 1, "optional": False, + "input": "textarea", + "markdown": True, "type": "string" } }, @@ -1093,6 +1073,8 @@ "param": { "minLength": 1, "optional": False, + "input": "textarea", + "markdown": True, "type": "string" } }, @@ -1254,6 +1236,8 @@ "param": { "minLength": 1, "optional": True, + "input": "textarea", + "markdown": True, "type": "string" } }, @@ -1265,6 +1249,8 @@ "param": { "minLength": 1, "optional": True, + "input": "textarea", + "markdown": True, "type": "string" } }, @@ -1276,6 +1262,8 @@ "param": { "minLength": 1, "optional": False, + "input": "textarea", + "markdown": True, "type": "string", "default": "There are no concerns with this submission" } diff --git a/tests/test_arr_venue_v2.py b/tests/test_arr_venue_v2.py index bb66f3c7f..dc68771f0 100644 --- a/tests/test_arr_venue_v2.py +++ b/tests/test_arr_venue_v2.py @@ -529,7 +529,6 @@ def test_june_cycle(self, client, openreview_client, helpers, test_client): 'consent_to_share_submission_details': { 'value': 'On behalf of all authors, we agree to the terms above to share our submission details.' }, "A1_limitations_section": { 'value': 'This paper has a limitations section.' }, "A2_potential_risks": { 'value': 'Yes' }, - "A3_abstract_and_introduction_summarize_claims": { 'value': 'Yes' }, "B_use_or_create_scientific_artifacts": { 'value': 'Yes' }, "B1_cite_creators_of_artifacts": { 'value': 'Yes' }, "B2_discuss_the_license_for_artifacts": { 'value': 'Yes' }, @@ -1146,7 +1145,6 @@ def test_submission_preprocess(self, client, openreview_client, test_client, hel 'consent_to_share_submission_details': { 'value': 'On behalf of all authors, we agree to the terms above to share our submission details.' }, "A1_limitations_section": { 'value': 'This paper has a limitations section.' }, "A2_potential_risks": { 'value': 'Yes' }, - "A3_abstract_and_introduction_summarize_claims": { 'value': 'Yes' }, "B_use_or_create_scientific_artifacts": { 'value': 'Yes' }, "B1_cite_creators_of_artifacts": { 'value': 'Yes' }, "B2_discuss_the_license_for_artifacts": { 'value': 'Yes' }, @@ -2064,7 +2062,6 @@ def test_submissions(self, client, openreview_client, helpers, test_client): 'consent_to_share_submission_details': { 'value': 'On behalf of all authors, we agree to the terms above to share our submission details.' }, "A1_limitations_section": { 'value': 'This paper has a limitations section.' }, "A2_potential_risks": { 'value': 'Yes' }, - "A3_abstract_and_introduction_summarize_claims": { 'value': 'Yes' }, "B_use_or_create_scientific_artifacts": { 'value': 'Yes' }, "B1_cite_creators_of_artifacts": { 'value': 'Yes' }, "B2_discuss_the_license_for_artifacts": { 'value': 'Yes' },