Fix/ Edge Browser: support textbox input when the edit invitation is not an enum #2095
Conversation
| return column | ||
| }) | ||
| return { columns: resultColumns } | ||
| }) |
There was a problem hiding this comment.
data loading is updated to avoid state update conflict
reloadColumnEntities update was overwritting state update from updateChildColumns
|
How does a default value work here? Because when I set a default value and I try to assign a reviewer that already has that number of assignments, the edge browser won't let me make the assignment, but I don't see this default value anywhere and it's not clear why I can't make the assignment. Also, it is not very straightforward how to change this value, and changing it is not very smooth. Not sure if this will be a good experience for PCs. |
|
please elaborate what makes you think it's not clear/smooth
|
There was a problem hiding this comment.
A few things:
I think the trash icon should look the same as the Assignment one:
If you put invalid input, the spinner goes on forever with no way of editing your previous input. I think the expected behavior is to immediately edit and fix the issue. Otherwise you have to click another paper and click back, or trash the edge (if it exists):
I think we should also have some way of telling the PCs what the expected input is now that it's a textbox.
There was a problem hiding this comment.
The issues I mentioned have been fixed and I think it looks good. I was worried that the expected values/range wasn't as clear as it was with the dropdown, but I checked again and I think the validation errors are clear enough.
Example with and without a default (of 6):
this pr should allow a textbox in edge browser to add/edit edge
example for weight of custom max papers:
should show a textbox for custom max papers edge