Skip to content
This repository has been archived by the owner on Nov 7, 2024. It is now read-only.

Results from a branch are pushed to a release-candidates branch based on master #17

Open
alexwalkerepi opened this issue Apr 27, 2021 · 0 comments

Comments

@alexwalkerepi
Copy link

This workspace is based on this NCS-historical-health branch. When I pushed results using osrelease, it pushed them to a release-candidates branch that was based on master, meaning that the subsequent PR to merge with the NCS-historical-health branch had a load of unwanted code changes.

From @bloodearnest:

I think there are two issue: osrelease bases release-candidates branch of the default branch if it doesn't exist. But also, it reuses it if it does. Which is fine, as long as the user has deleted old versions of that branch once results have been merged. But if not, it can cause all kinds of issues (e.g. old release-candidates branch being based on master when you're working on a branch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant