Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate reader package #15

Open
puerco opened this issue Oct 22, 2022 · 16 comments · May be fixed by #45
Open

Deprecate reader package #15

puerco opened this issue Oct 22, 2022 · 16 comments · May be fixed by #45
Labels
good first issue Good for newcomers

Comments

@puerco
Copy link
Member

puerco commented Oct 22, 2022

The reader package seems to be a little bit overkill, maybe we should deprecate it.

/cc @cpanato

@puerco puerco added the good first issue Good for newcomers label Oct 22, 2022
@cpanato
Copy link
Collaborator

cpanato commented Oct 24, 2022

i will work on that

@cpanato
Copy link
Collaborator

cpanato commented Oct 24, 2022

need #14 to get in

@devanshcache
Copy link

Is this issue solved or still need to work on it? @cpanato @puerco

@cpanato
Copy link
Collaborator

cpanato commented Mar 12, 2023

i think that still need to be done

@Ash-KODES
Copy link

Can I make a PR for this ? @cpanato

@devanshcache
Copy link

devanshcache commented Mar 12, 2023

Thank you for your response @cpanato. sorry i am new to open source but what exactly do you mean by "deprecate it"?

@Ash-KODES
Copy link

Thank you for your response @cpanato. sorry i am new to open source but what exactly do you mean by "deprecate it"?

Hi, Devansh
Deprecation means we will not be using this package now.
btw, I have committed a few changes and started working on this one, can you please take up some other issues?
thanks.

@devanshcache
Copy link

Thank you for your response @cpanato. sorry i am new to open source but what exactly do you mean by "deprecate it"?

Hi, Devansh Deprecation means we will not be using this package now. btw, I have committed a few changes and started working on this one, can you please take up some other issues? thanks.

Can i see your commits?

@Ash-KODES
Copy link

yup, sure,
let me make a PR once:)

@Ash-KODES Ash-KODES linked a pull request Mar 12, 2023 that will close this issue
@Ash-KODES
Copy link

Ash-KODES commented Mar 12, 2023

Hii @cpanato @puerco
Can you please review my work (so that I am going on the right track here) so that I can make further commits?
Thank you.

@devanshcache
Copy link

Can I do the rest? if your pull request is approved. As there isn't any more good first issue? @Ash-KODES

@Ash-KODES
Copy link

Ash-KODES commented Mar 12, 2023

Can I do the rest? if your pull request is approved. As there isn't any more good first issue? @Ash-KODES

Hey @git-devansh , Can you please work on some different issues, if you don't mind?
there are a lot of open issues right now, you can work on them
There are some quality assessment testing issues at the end of the issue board you can work on them, they are also kind of beginner friendly.
Also, you can create your own issue, either enhancement or bug:)

@puerco
Copy link
Member Author

puerco commented Mar 13, 2023

@Ash-KODES cool I added a few comments to the PR, if you want to split the work it is fine too!

@Ash-KODES
Copy link

Ash-KODES commented Mar 13, 2023

@Ash-KODES cool I added a few comments to the PR, if you want to split the work it is fine too!

thanks, but would like a complete this one by myself, since want to get into yarn and npm implementation because also had some enhancement ideas for them as proposals.

@nishakm
Copy link
Contributor

nishakm commented Mar 14, 2023

@Ash-KODES cool I added a few comments to the PR, if you want to split the work it is fine too!

thanks, but would like a complete this one by myself, since want to get into yarn and npm implementation because also had some enhancement ideas for them as proposals.

I'm working on the npm implementation, but you can collaborate on my PR: #35

@Ash-KODES
Copy link

@Ash-KODES cool I added a few comments to the PR, if you want to split the work it is fine too!

thanks, but would like a complete this one by myself, since want to get into yarn and npm implementation because also had some enhancement ideas for them as proposals.

I'm working on the npm implementation, but you can collaborate on my PR: #35

Sure @nishakm :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants