Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] support ExtendedSocketOption in highlevelClient #15927

Open
kkewwei opened this issue Sep 13, 2024 · 3 comments · May be fixed by #16757
Open

[Feature Request] support ExtendedSocketOption in highlevelClient #15927

kkewwei opened this issue Sep 13, 2024 · 3 comments · May be fixed by #16757
Labels
Clients Clients within the Core repository such as High level Rest client and low level client enhancement Enhancement or improvement to existing feature or request

Comments

@kkewwei
Copy link
Contributor

kkewwei commented Sep 13, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe

Now httpcomponents supports ExtendedSocketOption（TCP_KEEPIDLE, TCP_KEEPINTERVAL, TCP_KEEPCOUNT ） in apache/httpcomponents-core#473, and releases the 5.3.

Describe the solution you'd like

If we can upgrade the httpcore5 version from 5.2.5 to 5.3 and use the ExtendedSocketOption in highlevelClient? I'm pleasure to do it.

Related component

Clients

Describe alternatives you've considered

No response

Additional context

No response
@kkewwei kkewwei added enhancement Enhancement or improvement to existing feature or request untriaged labels Sep 13, 2024
@github-actions github-actions bot added the Clients Clients within the Core repository such as High level Rest client and low level client label Sep 13, 2024
@dblock dblock removed the untriaged label Oct 7, 2024
@dblock
Copy link
Member

dblock commented Oct 7, 2024

[Catch All Triage - 1, 2, 3, 4]

@kkewwei
Copy link
Contributor Author

kkewwei commented Nov 28, 2024

@dblock @reta, please have a look, it seems worthwhile to implement, and i like have a try.

@reta
Copy link
Collaborator

reta commented Nov 28, 2024

@kkewwei sure, please go ahead (please don't forget to update the httpclient5 to 5.4.1 or above if available), thank you

@kkewwei kkewwei linked a pull request Dec 2, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clients Clients within the Core repository such as High level Rest client and low level client enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade HttpCore5/HttpClient5 to support ExtendedSocketOption in HttpAsyncClient kkewwei/OpenSearch
3 participants
@reta @dblock @kkewwei