Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][data-prepper] Empty objects pruned during helm values merge #625

Open
janhoy opened this issue Dec 4, 2024 · 1 comment · May be fixed by #626
Open

[BUG][data-prepper] Empty objects pruned during helm values merge #625

janhoy opened this issue Dec 4, 2024 · 1 comment · May be fixed by #626
Labels
bug Something isn't working

Comments

@janhoy
Copy link
Contributor

janhoy commented Dec 4, 2024

Describe the bug
Some sample values in helm chart's values file define empty object implicitly by a dangling colon:

      source:
        random:

While this works for a plain helm install, it will crash when using override values since the yaml merge will think it is an empty useless object and prune it, causing source: {}. To avoid this, be explicit about the empty object:

      source:
        random: {}

I believe the simple-sample-pipeilne should not be in default values at all (see #624 ), but no matter where the sample pipeline is referenced (chart, documentation, website), it should use the best practice of explicitly defining the empty object.

To Reproduce
Steps to reproduce the behavior:

  1. Install the helm chart with a simple override values file that do not touch the pipelineConfig at all
  2. Watch the secret contains an empty source and pipeline fails due to lack of configured source.

Expected behavior
Expected the random source not to be lost at helm install.

Chart Name
data-prepper

@janhoy janhoy added bug Something isn't working untriaged Issues that have not yet been triaged labels Dec 4, 2024
janhoy added a commit to janhoy/opensearch-helm-charts that referenced this issue Dec 4, 2024
@prudhvigodithi prudhvigodithi removed the untriaged Issues that have not yet been triaged label Dec 5, 2024
@prudhvigodithi
Copy link
Member

[Triage]
Thanks for the contribution @janhoy, adding @TheAlgo @peterzhuamazon to please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🆕 New
2 participants