Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] timeZone not implemented in CompositeDateHistogramAggregationSource #1142

Closed
yyj1219 opened this issue Aug 15, 2024 · 2 comments · Fixed by #1362
Closed

[BUG] timeZone not implemented in CompositeDateHistogramAggregationSource #1142

yyj1219 opened this issue Aug 15, 2024 · 2 comments · Fixed by #1362
Labels
bug Something isn't working

Comments

@yyj1219
Copy link

yyj1219 commented Aug 15, 2024

What is the bug?

timeZone not implemented in CompositeDateHistogramAggregationSource.

How can one reproduce the bug?

CompositeDateHistogramAggregationSource.of(cdha -> cdha
        .field("time")
        .fixedInterval(Time.of(t -> t.time("1h")))
        .timeZone("Asia/Seoul")
);

I expected timeZone(), but there is zoneId().
However, in OpenSearch 2.13, CompositeDateHistogramAggregationSource only supports time_zone and does not support zone_id.

What is the expected behavior?

Please add timeZone().

What is your host/environment?

OpenSearch 2.13 and OpenSearch Java Client 2.13

@yyj1219 yyj1219 added bug Something isn't working untriaged labels Aug 15, 2024
@Xtansia Xtansia removed the untriaged label Aug 28, 2024
@Xtansia
Copy link
Collaborator

Xtansia commented Aug 28, 2024

@yyj1219 Thanks for reporting this! Would you be interested in contributing a PR to add this? It would be very welcomed if so 😄

@yyj1219
Copy link
Author

yyj1219 commented Aug 30, 2024

@Xtansia Alright, I'll give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants