Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Deprecate hand-coded index_management in favor of auto-generated ism. #831

Open
dblock opened this issue Sep 27, 2024 · 1 comment
Labels
api support enhancement New feature or request

Comments

@dblock
Copy link
Member

dblock commented Sep 27, 2024

Is your feature request related to a problem?

Coming from #830, the OpenSearch API spec has added ISM in opensearch-project/opensearch-api-specification#568. However opensearch-py already has index_management (different name) and the auto-generated implementation is not compatible because it re-orders body and index parameters.

What solution would you like?

  1. Add support for reordering parameters in api generator and swap index and body in the case of ISM for backwards-compat.
  2. Deprecate IndexManagementClient and implement it by inheriting auto-generated IsmClient instead.

What alternatives have you considered?

A breaking change where we delete IndexManagementClient and use the generated IsmClient.

@dblock dblock added enhancement New feature or request untriaged Need triage api support and removed untriaged Need triage labels Sep 27, 2024
@github-actions github-actions bot added the untriaged Need triage label Sep 27, 2024
@dblock dblock removed the untriaged Need triage label Oct 21, 2024
@dblock
Copy link
Member Author

dblock commented Oct 21, 2024

[Catch All Triage - 1, 2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api support enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant