Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Use self-hosted popper.js instead of the unpkg.com hosted JS. #3385

Open
nateynateynate opened this issue Oct 14, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@nateynateynate
Copy link
Member

Describe the bug

As part of a recent CVE we're ensuring that no scripts are being loaded externally to the site from places like unpkg.com.

Currently the only instance of unpkg I could find was for popper.js. Let's take care of that first. Then we can comb through for any other instances of externally hosted JS.

Expected behavior

All javascript should be hosted locally.

Screenshots

image

"popperjs" being loaded from unpkg.com

To Reproduce

Use developer console to view 'network' tab to see the domain we're pulling from.

Additional Details

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@nateynateynate nateynateynate added bug Something isn't working untriaged and removed untriaged labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant