Skip to content
This repository has been archived by the owner on Jul 23, 2020. It is now read-only.

[1] Improve unit test code coverage for fabric8-data-importer above 90% #2855

Closed
2 tasks done
tisnik opened this issue Apr 3, 2018 · 2 comments
Closed
2 tasks done

Comments

@tisnik
Copy link
Collaborator

tisnik commented Apr 3, 2018

Acceptance criteria:

@tisnik
Copy link
Collaborator Author

tisnik commented Apr 3, 2018

Actual code coverage report:

Name                                      Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------
src/__init__.py                               2      0   100%
src/config.py                                22      0   100%
src/data_importer.py                        195     32    84%   86, 97, 120-131, 158, 177-178, 215-217, 264-266, 274-275, 282-295, 307, 312, 317, 322, 327, 343, 348, 353
src/data_source/__init__.py                   0      0   100%
src/data_source/abstract_data_source.py       6      0   100%
src/data_source/s3_data_source.py            36      2    94%   29-31
src/graph_manager.py                         38      0   100%
src/graph_populator.py                      176      1    99%   385
src/rest_api.py                              97     15    85%   35-39, 97, 100-102, 113-115, 124, 155, 161
-----------------------------------------------------------------------
TOTAL                                       572     50    91%

this is clearly higher that the specified threshold :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant