Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wyszukiwarka pomija niektóre obiekty #54

Open
Ancymonek opened this issue Mar 10, 2021 · 3 comments
Open

Wyszukiwarka pomija niektóre obiekty #54

Ancymonek opened this issue Mar 10, 2021 · 3 comments
Labels

Comments

@Ancymonek
Copy link

Wyszukiwarka Mapboxa pomija niektóre obiekty, przykład: miasto Krotoszyn w województwie wielkopolskim:

obraz

vs wyniki zwracane przez https://labs.mapbox.com/geocoder-feedback/

obraz

Wstępna analiza Tomka wskazała, że możliwe, iż niektóre miasta są traktowane jako POI.

@ttomasz
Copy link
Contributor

ttomasz commented Apr 13, 2021

Mail wysłany do supportu Mapboxa w odpowiedzi na prośbę o więcej informacji o co mi chodzi:

 I'll try to ilustrate with mapbox search playground:
https://docs.mapbox.com/search-playground/#{%22url%22:%22%22,%22index%22:%22mapbox.places%22,%22approx%22:true,%22staging%22:false,%22onCountry%22:true,%22onWorldview%22:false,%22onType%22:true,%22onProximity%22:false,%22onBBOX%22:false,%22onLimit%22:true,%22onLanguage%22:true,%22countries%22:[{%22name%22:%22Poland%22,%22code%22:%22pl%22}],%22worldviews%22:[],%22proximity%22:%22%22,%22typeToggle%22:{%22country%22:true,%22region%22:true,%22district%22:true,%22postcode%22:true,%22locality%22:true,%22place%22:true,%22neighborhood%22:true,%22address%22:true,%22poi%22:false},%22types%22:[%22country%22,%22region%22,%22district%22,%22postcode%22,%22locality%22,%22place%22,%22neighborhood%22,%22address%22],%22bbox%22:%22%22,%22limit%22:%22%22,%22autocomplete%22:true,%22languages%22:[{%22code%22:%22pl%22,%22name%22:%22Polish%22}],%22languageStrict%22:false,%22onDebug%22:false,%22selectedLayer%22:%22%22,%22debugClick%22:{},%22localsearch%22:false,%22query%22:%22Krotoszyn%22}

Notice that when you don't filter out POI category (as in POIs are included in the search) you can see city of Krotoszyn. When you filter out POI and leave searching by Locality, Place, etc. you don't see Krotoszyn in the results.

Node that I sent url to in first message represents city which should be included in Locality or Place but for some reason it's included in POI category of the search.

Please let me know if you have any questions.
I'd like to know why this point is classified as POI whether it's a mapbox bug or tagging of the osm node is wrong and why.

Best regards

@ttomasz
Copy link
Contributor

ttomasz commented May 20, 2021

Jordan (Mapbox)

May 19, 2021, 9:41 AM PDT
Hi Tomasz​,

Thanks for reaching out with more details about this and the feedback on our Geocoding API. Our search product does use OSM in part, but it's not the only source and it's not the single source of truth for which it relies. We're always adding to our search data and functionality and would love your help. If you have any search feedback, you can use this tool to let us know. Our Search team reviews and aggregates feedback submitted there to prioritize areas where we may need to source, vet, test, and add new data sources. If your feedback is related to point of interest data (like a business or school), please select "Yes" to answer the question "Is this a Point of Interest?" so we will triage that to the right team.

I'd also recommend testing your searches and using parameters to filter your search with our API playground.


	

Tomasz

May 17, 2021, 3:16 PM PDT
Hi Jordan,

thanks for investigating but I am not convinced that this is the case here.

In the provided example we are looking specifically for the city of Krotoszyn which is represented in OpenStreetMap (which is the data source for Mapbox service as far as I know - except for POI as you mentioned).

This is the relation in OSM which represents the city of Krotoszyn: https://www.openstreetmap.org/relation/2705296
part of this relation is the point representing city center: https://www.openstreetmap.org/node/31797403

Both of those contain "name" and "name:pl" tag with the name: "Krotoszyn". So both have generic name which can be searched for and even translated name (in this case it is the same since Krotoszyn is in Poland).

Both of those object also link to wikipedia: https://pl.wikipedia.org/wiki/pl:Krotoszyn?uselang=pl
and wikidata: https://www.wikidata.org/wiki/Q984538
Wikidata contains the name in multiple languages including Polish and English.

So the data is there. Those objects have correct names abd should be searchable.

I tried turning off filtering by language or changing the filtering to english in the geocoding playground but neither action changed results for the query.

The only layer that returns correct result for query: "Krotoszyn" is POI.

Either Mapbox geocoding is using other data for geocoding or for whatever reason this particular city is filtered out of "place" layer.
If it's the latter then it's either bug in Mapbox data processing/geocoder or there is something wrong with how the object is tagged (if that's the case i would like to know exactly why).

If this problem is reproducible on your end and we can agree that this object should be searchable with the catgory "place" or "locality" since it has the name available in multiple languages then please escalate this to engineers from the product team responsible.

Please keep me informed. Thank you.

Best regards
Tomasz



	

Jordan (Mapbox)

May 17, 2021, 10:13 AM PDT
Then we actually figure out what was really going on. We did some more testing using your api calls, we found out the issue was due to using the language

Normally that makes sense that you would want `language=polish` but — in our case, place features don’t have as many “polish” translations as the POI features do.  So, most of our places data gets translations from wikidata, and when it’s a country there will be a definite match and a long list of translations in all different languages for that country. When it’s something much smaller like a locality or neighborhood, it’s very much hit or miss if that feature actually has any translation data at all.

On the other hand, POI data tends to get more translations because it’s sourced from a paid provider. So when you query:
language=en, type=POI++++ (POI and all the other types),limit=5 , you are automatically prioritizing those features with translations over those features without translations. This is why we are seeing more POIs with english translation prioritized over the neighborhood.

What you can do is either:

    Turning off Language=polish , or
     Turn off searching for address,POI


Thanks for reading so far :) Please let me know if this was clear, or if you have any more questions. 

	

Tomasz

Apr 8, 2021, 11:50 AM PDT
Hi Jordan,

I'll try to ilustrate with mapbox search playground:
https://docs.mapbox.com/search-playground/#{%22url%22:%22%22,%22index%22:%22mapbox.places%22,%22approx%22:true,%22staging%22:false,%22onCountry%22:true,%22onWorldview%22:false,%22onType%22:true,%22onProximity%22:false,%22onBBOX%22:false,%22onLimit%22:true,%22onLanguage%22:true,%22countries%22:[{%22name%22:%22Poland%22,%22code%22:%22pl%22}],%22worldviews%22:[],%22proximity%22:%22%22,%22typeToggle%22:{%22country%22:true,%22region%22:true,%22district%22:true,%22postcode%22:true,%22locality%22:true,%22place%22:true,%22neighborhood%22:true,%22address%22:true,%22poi%22:false},%22types%22:[%22country%22,%22region%22,%22district%22,%22postcode%22,%22locality%22,%22place%22,%22neighborhood%22,%22address%22],%22bbox%22:%22%22,%22limit%22:%22%22,%22autocomplete%22:true,%22languages%22:[{%22code%22:%22pl%22,%22name%22:%22Polish%22}],%22languageStrict%22:false,%22onDebug%22:false,%22selectedLayer%22:%22%22,%22debugClick%22:{},%22localsearch%22:false,%22query%22:%22Krotoszyn%22}

Notice that when you don't filter out POI category (as in POIs are included in the search) you can see city of Krotoszyn. When you filter out POI and leave searching by Locality, Place, etc. you don't see Krotoszyn in the results.

Node that I sent url to in first message represents city which should be included in Locality or Place but for some reason it's included in POI category of the search.

Please let me know if you have any questions.
I'd like to know why this point is classified as POI whether it's a mapbox bug or tagging of the osm node is wrong and why.

Best regards
Tomasz

	

Jordan Webb (Mapbox)

Apr 5, 2021, 6:13 PM PDT
Hi Tomasz​,

To help me answer your request, can you please provide the following information:

    What were you expecting to see in the results?
    What types of constraints are you hoping to apply to your search query?
    Can you provide the Geocoding API request url you used to run this search? It will look something like this, and may include additional parameters after your access token:

    https://api.mapbox.com/geocoding/v5/mapbox.places/divisadero%20street%20san%20francisco%20california.json?access_token={YOUR ACCESS TOKEN}


If you're able to share the above information, this will allow me to take a look at your parameters and replicate what you're seeing.

mapbox nas olał

@ttomasz
Copy link
Contributor

ttomasz commented May 20, 2021

można spróbować przepiąc geokoder na ten gugikowy, tam tylko trzeba zrobić funkcję, która odpowiedź z ich api przerobi na format akceptowalny przez ten widget geokodera

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants