Skip to content
This repository has been archived by the owner on Nov 25, 2022. It is now read-only.

applyVideoFilter not working #233

Open
gustavostuff opened this issue Aug 3, 2022 · 1 comment
Open

applyVideoFilter not working #233

gustavostuff opened this issue Aug 3, 2022 · 1 comment

Comments

@gustavostuff
Copy link

gustavostuff commented Aug 3, 2022

There's some code without context in here but still, this seems to work OK:

let publisherData = {
  resolution,
  audioSource: this.normalizeSource(config.audioSource),
  videoSource: this.normalizeSource(config.videoSource),
  name: id,
  showControls: false,
  frameRate: fps,
  insertDefaultUI: false,
  publishAudio: !isMuted,
  publishVideo: !isHidden,
  videoFilter: {
    type: 'backgroundBlur'  // <-- Sending filter here
  }
};

let pub = OT.initPublisher(
  undefined, {
    ...publisherData
  }, (error: OT.OTError) => {
    console.error('There was an error while initializing the publisher', error);
  }
);
this.publishers.set(id, pub);

Result:
blur.png

While this doesn't:

let publisherData = {
  resolution,
  audioSource: this.normalizeSource(config.audioSource),
  videoSource: this.normalizeSource(config.videoSource),
  name: id,
  showControls: false,
  frameRate: fps,
  insertDefaultUI: false,
  publishAudio: !isMuted,
  publishVideo: !isHidden,
};

let pub = OT.initPublisher(
  undefined, {
    ...publisherData
  }, (error: OT.OTError) => {
    console.error('There was an error while initializing the publisher', error);
  }
);
pub.applyVideoFilter({     //  <-- Doing it here instead
  type: 'backgroundBlur'
});
this.publishers.set(id, pub);

Result:
noblur.png

@gustavostuff
Copy link
Author

gustavostuff commented Aug 4, 2022

I just realized this may not be the correct repo for this, but still, this is core functionality. We're using OpenTok by importing:
<script src="https://static.opentok.com/v2.23.1/js/opentok.min.js"></script>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant