Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make's target ../run/dynacomptest is broken; also add it to CI? #5536

Open
AlekseyCherepanov opened this issue Sep 15, 2024 · 2 comments
Open
Assignees
Labels
testing A testing task or issue (e.g., with CI)

Comments

@AlekseyCherepanov
Copy link
Member

../run/dynacomptest is not built by default and it seems outdated.

$ make ../run/dynacomptest
[...]
dynamic_compiler.c: In function ‘dynamic_assign_script_to_format’:
dynamic_compiler.c:2639:45: error: ‘options’ undeclared (first use in this function); did you mean ‘optind’?

(I found the target because it was the only user of UNICODE_NO_OPTIONS that I needed for tests in #5531. There I'll fix a problem with options used in unicode.h.)

BTW it could work on CI as other tests in make check, could not it?

@AlekseyCherepanov
Copy link
Member Author

Error in my previous message is from modified Makefile.in. Normal build fails earlier:

make: *** No rule to make target 'base64.o', needed by '../run/dynacomptest'.  Stop.

@solardiz solardiz added the testing A testing task or issue (e.g., with CI) label Sep 16, 2024
@solardiz
Copy link
Member

I wasn't even aware of this make target.

@AlekseyCherepanov Is this something you want to fix? If so, please give it a try. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing A testing task or issue (e.g., with CI)
Projects
None yet
Development

No branches or pull requests

2 participants